feat(datagen): add SystemIdentity with OS/arch/role types and version pools#147
Open
Conversation
This was referenced Apr 27, 2026
Contributor
Author
This was referenced Apr 27, 2026
Dylan-M
force-pushed
the
04-06-feat_datagen_add_domainidentity_and_certauthority_generation
branch
from
9b49fe7 to
a58b606
Compare
Dylan-M
force-pushed
the
04-06-feat_datagen_add_systemidentity_with_os_arch_role_types_and_version_pools
branch
from
c9aa453 to
32a0573
Compare
Dylan-M
force-pushed
the
04-06-feat_datagen_add_domainidentity_and_certauthority_generation
branch
from
a58b606 to
ba4203d
Compare
Dylan-M
force-pushed
the
04-06-feat_datagen_add_systemidentity_with_os_arch_role_types_and_version_pools
branch
from
32a0573 to
e0447ff
Compare
eKuG
approved these changes
May 8, 2026
| SANs []string // [FQDN, hostname, IPv4] | ||
| } | ||
|
|
||
| // GenerateSystemIdentity creates a system with the given OS, role, and domain context. |
There was a problem hiding this comment.
Nit: It dereferences domain.Name and domain.CA.CommonName unconditionally, so a nil domain or a DomainIdentity without a CA will panic
Contributor
Author
There was a problem hiding this comment.
Added explicit nil-checks at the top of GenerateSystemIdentity for domain and domain.CA. Matches the package's existing mustParseCIDRs panic-on-developer-error pattern from #145. New test verifies both panics fire.
Filed PIPE-1003 to convert all Generate* functions in internal/datagen from panic to error returns ahead of PIPE-975 (embed seam). Library panics propagating into a host process aren't acceptable once blitz is embeddable; that ticket plans the conversion before the embed surface gets exposed.
Dylan-M
force-pushed
the
04-06-feat_datagen_add_domainidentity_and_certauthority_generation
branch
from
ba4203d to
c919f87
Compare
Dylan-M
force-pushed
the
04-06-feat_datagen_add_systemidentity_with_os_arch_role_types_and_version_pools
branch
from
e0447ff to
e233d6f
Compare
Dylan-M
force-pushed
the
04-06-feat_datagen_add_domainidentity_and_certauthority_generation
branch
from
c919f87 to
3a8183d
Compare
Dylan-M
force-pushed
the
04-06-feat_datagen_add_systemidentity_with_os_arch_role_types_and_version_pools
branch
from
e233d6f to
61eae75
Compare
Dylan-M
force-pushed
the
04-06-feat_datagen_add_domainidentity_and_certauthority_generation
branch
from
3a8183d to
c95013d
Compare
Dylan-M
force-pushed
the
04-06-feat_datagen_add_systemidentity_with_os_arch_role_types_and_version_pools
branch
from
61eae75 to
e16eaac
Compare
Dylan-M
force-pushed
the
04-06-feat_datagen_add_domainidentity_and_certauthority_generation
branch
from
c95013d to
6328197
Compare
Dylan-M
force-pushed
the
04-06-feat_datagen_add_systemidentity_with_os_arch_role_types_and_version_pools
branch
from
e16eaac to
cb53fb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Change
Adds
SystemIdentity, including OS, architecture, role types, and version pools.Part of PIPE-927 common data generation package stack. Foundation for PIPE-785, PIPE-928, PIPE-943, and the rest of the simulator stack.
Checklist